-
Notifications
You must be signed in to change notification settings - Fork 12
75 add t doc #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hpowley
wants to merge
32
commits into
master
Choose a base branch
from
75_add_tDOC
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
75 add t doc #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be safeguard the model in respect to upcoming changes to the light modules and allow for easier coupliong to spectral light module
COMPILES - DOESN'T RUN
DOESNOT CONSERVE MASS WHEN PHOTOAGING>0
…e_exchange_ need a flux in mgC/m2/d the surface_photolysis diagnostic save the flus in mgC/m3/d because this is what is more senisble to save and use in the analysis
Member
Author
|
I've fixed the issue with the checks. This is now ready to be checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Work
Add in LOCATE branch from ersem-dev and make new fabm.yaml file for GOTM based on Powley et al. manuscript
Fixes #75
Testing Instructions
1.Check bacteria_docdyn file as had merge conflicts
2. Check compiles with GOTM
3. Check fabm.yaml file runs using GOTM