2025.11.19.1609 #34
Merged
2025.11.19.1609 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the CI workflow, build configuration, and extends the cortex API with new state-reading functions. The changes prepare the project for improved CI/CD with a new build job and add functionality for reading neuron state information.
- Renames and restructures the CI workflow from CodeQL-focused to a broader CI workflow with CodeQL analysis and build verification
- Updates tool versions in the CI workflow (checkout v4→v5, codeql analyze v3→v4)
- Changes C compiler standard from C17 to C11 for broader compatibility
- Adds two new API functions for reading cortex neuron state: spiking state and synapse output count
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.txt | Updates version hash to track the new release |
| include/unknown.h | Adds blank line for formatting consistency |
| include/cortex.h | Adds c2d_get_spiking_state and c2d_get_synout_state functions to read neuron states |
| Makefile | Changes C standard from C17 to C11 for compatibility |
| .github/workflows/ci.yml | Renames workflow, updates action versions, adds build job with dependency installation |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:31
- The CodeQL init action is still using v3 while the analyze action was updated to v4. For consistency and to avoid potential compatibility issues, consider updating this to v4 as well:
github/codeql-action/init@v4.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the CI workflow, build process, and cortex API. The main changes include renaming and updating the CI workflow, adding a new build job, updating tool versions, and extending the cortex API with new state-reading functions.
CI Workflow and Build Process Updates:
.github/workflows/codeql.ymlto.github/workflows/ci.ymland changed the workflow name fromCODEQL_ADVANCEDtoCI, updating the trigger branches pattern.DYNAMIC ANALYSIS, switched the checkout and analyze actions to newer major versions (actions/checkout@v5,github/codeql-action/analyze@v4), and added top-levelpermissions. [1] [2] [3]buildjob to the workflow, which installs build dependencies and runsmakeafter CodeQL analysis completes.Code and API Updates:
Makefilefrom C17 to C11 for compatibility.include/cortex.h:c2d_get_spiking_state(returns spiking state of neurons) andc2d_get_synout_state(returns output synapse counts for each neuron).