Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Conversation

@igchor
Copy link
Contributor

@igchor igchor commented Aug 11, 2022

This change is Reviewable

Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1, all commit messages.
Reviewable status: 8 of 9 files reviewed, 3 unresolved discussions (waiting on @igchor and @lukaszstolarczuk)


CONTRIBUTING.md line 177 at r1 (raw file):

applications do not crash. It is useful for Rapidcheck tests (it makes shrinking possible) and for ctest.

To turn this feature on, set env variable PMEMSTREAM_HANDLE_SIGNAL_FOR_DEBUG=1 and add test_register_sighandlers()

perhaps mark a function with ``


CONTRIBUTING.md line 177 at r1 (raw file):

applications do not crash. It is useful for Rapidcheck tests (it makes shrinking possible) and for ctest.

To turn this feature on, set env variable PMEMSTREAM_HANDLE_SIGNAL_FOR_DEBUG=1 and add test_register_sighandlers()

this will work only in c++ tests, isn't it...?


tests/common/test_backtrace.h line 2 at r1 (raw file):

// SPDX-License-Identifier: BSD-3-Clause
/* Copyright 2015-2021, Intel Corporation */

-2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants