feat: compatible with pydantic 2.12 and python 3.14#66
feat: compatible with pydantic 2.12 and python 3.14#66pmdevita merged 7 commits intopmdevita:masterfrom
Conversation
35fe0e7 to
df357b6
Compare
|
@bolinocroustibat I think everything should be fixed with the CI and Pydantic 2.12, can you rebase this for Python 3.14? |
2e69da3 to
cdadcf7
Compare
Thanks for your reactivity on this. I rebased on upstream, CI tests seem not to pass though and I'm not sure why. |
|
I might have it working now, can you try and rebase again? Sorry about this, it's a bit tough to test how the workflow runs for forks |
# Conflicts: # .github/workflows/test_full.yml
5df80d1 to
28a4008
Compare
…l.flit.metadata], not both"
No worries. I rebased on upstream main and it seems OK now, well done. For some reason among the matrix tests executed in the CD/CI, I don't see any test for Python >3.12 even though it looks like it's correctly setup in the CI/CD config file, which gets me confused - but might be me having a GitHub Actions UX issue? |
|
The tests that run automatically use the workflow file that's in master, I just approved the run that will use your updated one so we should see that now |
|
The matrix versions exclusions was starting to become hard to read, I refactored it to make it simpler to read, with same exclusions |
pmdevita
left a comment
There was a problem hiding this comment.
Sorry for the late reply, should be close to getting this working
2a093ae to
c02284b
Compare
|
There's a new codepath added for 3.14 so the existing workflow running on pull_request_target failed. The pull_request action failed because it couldn't post the comment but it otherwise succeeded which we can see here https://github.com/pmdevita/django-shinobi/actions/runs/22315017561?pr=66 This should now all be fixed. Thank you @bolinocroustibat for the help! |
Attempt to solve #65