Skip to content

feat: compatible with pydantic 2.12 and python 3.14#66

Merged
pmdevita merged 7 commits intopmdevita:masterfrom
bolinocroustibat:feat/python-3.14
Feb 23, 2026
Merged

feat: compatible with pydantic 2.12 and python 3.14#66
pmdevita merged 7 commits intopmdevita:masterfrom
bolinocroustibat:feat/python-3.14

Conversation

@bolinocroustibat
Copy link
Contributor

@bolinocroustibat bolinocroustibat commented Jan 26, 2026

Attempt to solve #65

@pmdevita
Copy link
Owner

pmdevita commented Jan 26, 2026

There are currently some issues with mypy (#64) I'm working through as I try to get #56 merged through for Pydantic 2.12. Once I get those solved and that merged though, I'll take this as an update for Python 3.14.

@bolinocroustibat
Copy link
Contributor Author

bolinocroustibat commented Jan 26, 2026

m working through as I try to get #56 merged through for Pydantic 2.12. Once I get those solved and that merged though, I'll take this as an update for Python 3.14.

By the way, we could replace mypy with ty in a feature release to simplify maintenance

@pmdevita
Copy link
Owner

pmdevita commented Feb 3, 2026

@bolinocroustibat I think everything should be fixed with the CI and Pydantic 2.12, can you rebase this for Python 3.14?

@bolinocroustibat bolinocroustibat force-pushed the feat/python-3.14 branch 2 times, most recently from 2e69da3 to cdadcf7 Compare February 3, 2026 19:49
@bolinocroustibat
Copy link
Contributor Author

bolinocroustibat commented Feb 3, 2026

@bolinocroustibat I think everything should be fixed with the CI and Pydantic 2.12, can you rebase this for Python 3.14?

Thanks for your reactivity on this. I rebased on upstream, CI tests seem not to pass though and I'm not sure why.

@pmdevita
Copy link
Owner

pmdevita commented Feb 3, 2026

I might have it working now, can you try and rebase again? Sorry about this, it's a bit tough to test how the workflow runs for forks

@bolinocroustibat
Copy link
Contributor Author

I might have it working now, can you try and rebase again? Sorry about this, it's a bit tough to test how the workflow runs for forks

No worries. I rebased on upstream main and it seems OK now, well done.

For some reason among the matrix tests executed in the CD/CI, I don't see any test for Python >3.12 even though it looks like it's correctly setup in the CI/CD config file, which gets me confused - but might be me having a GitHub Actions UX issue?

@pmdevita
Copy link
Owner

pmdevita commented Feb 6, 2026

The tests that run automatically use the workflow file that's in master, I just approved the run that will use your updated one so we should see that now

@bolinocroustibat
Copy link
Contributor Author

bolinocroustibat commented Feb 10, 2026

The matrix versions exclusions was starting to become hard to read, I refactored it to make it simpler to read, with same exclusions

Copy link
Owner

@pmdevita pmdevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply, should be close to getting this working

@pmdevita
Copy link
Owner

There's a new codepath added for 3.14 so the existing workflow running on pull_request_target failed. The pull_request action failed because it couldn't post the comment but it otherwise succeeded which we can see here https://github.com/pmdevita/django-shinobi/actions/runs/22315017561?pr=66

This should now all be fixed. Thank you @bolinocroustibat for the help!

@pmdevita pmdevita merged commit e5e3824 into pmdevita:master Feb 23, 2026
174 of 176 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants