Spark-specific rounding#2
Draft
pmattione-nvidia wants to merge 6 commits intomain_conversion_branchfrom
Draft
Conversation
pmattione-nvidia
pushed a commit
that referenced
this pull request
Aug 4, 2025
As currently libcudf hides non-public symbols by default, stacktrace using C++ ABI `backtrace_symbols` no longer produces meaningful output. For example: ``` #0: gtests/STREAM_REDUCTION_TEST() [0x5bb586] #1: gtests/STREAM_REDUCTION_TEST() [0x6a742d] #2: gtests/STREAM_REDUCTION_TEST() [0x68a04e] ... rapidsai#8: /usr/lib64/libc.so.6 : __libc_start_main+0xe5 rapidsai#9: gtests/STREAM_REDUCTION_TEST() [0x53419e] unknown file: Failure C++ exception with description "cudf_identify_stream_usage found unexpected stream!" thrown in the test body. ``` This PR removes completely the stacktrace generation code. Closes rapidsai#18831. Also closes rapidsai#16724. Authors: - Nghia Truong (https://github.com/ttnghia) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Vyas Ramasubramani (https://github.com/vyasr) - Robert (Bobby) Evans (https://github.com/revans2) URL: rapidsai#19048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist