Skip to content

Conversation

@JohnBlackwell
Copy link
Contributor

@JohnBlackwell JohnBlackwell commented Jul 8, 2025

Test Plan

Test environment: https://console.plrl-dev-aws.onplural.sh/

Checklist

  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have deployed the agent to a test environment and verified that it works as expected.
    • Agent started successfully.
    • Logs are clean and do not contain errors.
    • Component trees are working as expected.
  • I have added tests to cover my changes.
  • If required, I have updated the Plural documentation accordingly.

@JohnBlackwell JohnBlackwell requested a review from a team as a code owner July 8, 2025 16:29
@linear
Copy link

linear bot commented Jul 8, 2025

@github-actions github-actions bot added the size/L label Jul 8, 2025
@JohnBlackwell JohnBlackwell changed the title John/prod 3699 add renderer pipeline support to manifest generation in feat: add renderer pipeline support to manifest generation in Jul 8, 2025
@github-actions github-actions bot added size/XL and removed size/L labels Aug 18, 2025
Copy link
Contributor

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@michaeljguarino
Copy link
Member

You need to make sure the pr checks pass (its our way of ensuring the code has been tested e2e before merge)

@JohnBlackwell JohnBlackwell force-pushed the john/prod-3699-add-renderer-pipeline-support-to-manifest-generation-in branch from 2fdeb2d to 8967428 Compare January 14, 2026 16:54
@socket-security
Copy link

socket-security bot commented Jan 14, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgithub.com/​pluralsh/​console/​go/​client@​v1.58.1 ⏵ v1.58.2100 +110010010070

View full report

return renderDefault(dir, svc, mapper)
}

var allManifests []unstructured.Unstructured
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is generally fine, but I think we need to ensure two things:

  1. The default renderer should still run. This helps with the primary usecase here of supporting a helm chart and some additional git sourced manifests in one shot
  2. allManifests needs to be deduped at the end (very possible you could have two renderers generate the same thing). My guess is there's dedupe elsewhere done the chain that can be imitated, otherwise it's just lo.UniqBy(...) with a key using gvk namespace + name of the unstructured resource

Copy link
Contributor Author

@JohnBlackwell JohnBlackwell Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify your first point? My understanding was that the default renderer would run 1) if no renderers were defined or 2) if >1 renderer is defined and one of them is AUTO with AUTO meaning to use the default renderer.

Are you saying that the default renderer should run every time regardless of what renderers are defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, in the case of a dup, which renderer version should be kept? ie. if both raw and helm are rendered and a dup is detected, do we want the raw or do we want the helm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No we should run it regardless, or at least if it's just a helm chart. The most common usecase here is i want to install a chart + a few crs, and that's the nicest solve to handle that.

  2. For dupes, just keep the last one in the chain, we can write some conditions on it, but for now that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants