OPES: second attempt at fixing NaN problem for intel compiler#993
Merged
carlocamilloni merged 1 commit intoplumed:v2.8from Nov 29, 2023
Merged
OPES: second attempt at fixing NaN problem for intel compiler#993carlocamilloni merged 1 commit intoplumed:v2.8from
carlocamilloni merged 1 commit intoplumed:v2.8from
Conversation
GiovanniBussi
added a commit
that referenced
this pull request
Nov 30, 2023
Same trick as used in #993
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #990
Unfortunately I cannot test the intel compiler on my machine. My guess is that previous attempt did not work because this line was optimized away
Anyway, I now completely removed any NaN and instead use a very unlikely default value, that in practice will do the same job.
Target release
I would like my code to appear in release v2.8
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests