_guessplumedroot now deletes the temporary file used to store the plumed output#1366
Open
Iximiel wants to merge 1 commit intoplumed:v2.9from
Open
_guessplumedroot now deletes the temporary file used to store the plumed output#1366Iximiel wants to merge 1 commit intoplumed:v2.9from
Iximiel wants to merge 1 commit intoplumed:v2.9from
Conversation
…med output In the mkstemp documentation there is the following sentence: > Unlike TemporaryFile(), the user of mkstemp() is responsible for > deleting the temporary file when done with it. So I decided to use the higher level routine to avoid putting a new file in the tmp dir every time I run some test (or the user tries to create a new input with the InputBuilder)
2 tasks
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the mkstemp documentation there is the following sentence:
So I changed the routine to use the higher level NamedTemporaryFile, to it will automatically delete the tmp file every time I run some test (or the user tries to create a new input with the InputBuilder)
Target release
I would like my code to appear in release v2.9
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests