Skip to content

_guessplumedroot now deletes the temporary file used to store the plumed output#1366

Open
Iximiel wants to merge 1 commit intoplumed:v2.9from
Iximiel:fix29/pythonInterfaceTmpFile
Open

_guessplumedroot now deletes the temporary file used to store the plumed output#1366
Iximiel wants to merge 1 commit intoplumed:v2.9from
Iximiel:fix29/pythonInterfaceTmpFile

Conversation

@Iximiel
Copy link
Member

@Iximiel Iximiel commented Feb 2, 2026

Description

In the mkstemp documentation there is the following sentence:

Unlike TemporaryFile(), the user of mkstemp() is responsible for
deleting the temporary file when done with it.

So I changed the routine to use the higher level NamedTemporaryFile, to it will automatically delete the tmp file every time I run some test (or the user tries to create a new input with the InputBuilder)

Target release

I would like my code to appear in release v2.9

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

…med output

In the mkstemp documentation there is the following sentence:
> Unlike TemporaryFile(), the user of mkstemp() is responsible for
> deleting the temporary file when done with it.

So I decided to use the higher level routine to avoid putting a new file
in the tmp dir every time I run some test (or the user tries to create
a new input with the InputBuilder)
@GiovanniBussi
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants