Adding the linked cells in the cudaCoordination#1359
Draft
Iximiel wants to merge 6 commits intoplumed:masterfrom
Draft
Adding the linked cells in the cudaCoordination#1359Iximiel wants to merge 6 commits intoplumed:masterfrom
Iximiel wants to merge 6 commits intoplumed:masterfrom
Conversation
starting to compact the Coordination part of the function set up the base for mocking some flexibility setting up a map for running the wanted kernel Now it should be easier to add new switching functions some cleaning correcting some regtest, better feedback on the number of atoms Now the cell calculations will be run ony at cell reset Changing the number of threads for more concurrency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I think that now the cudaCoordination has the correct shape:
Each kernel is one of the cells setup with the linkcells and runs on all the atoms in the cells and in the surrounding cells.
Now it is possible adding a new switching function without getting too crazy, with a some template shenanigans.
A next step could be set up a way to use non orthogonal pbc also in the kernels.
I wanted to post some benchmark but I encountered this problem:

I asked for a cutoff of 4 with atoms evenly distributed in a simple cubic arrangement with a cell size of 1, and I am getting cells of 125 atoms instead of 64 (with some cells that have less atoms).
I think this is a problem in linkcells in the way in which it is assigning atoms to their cells.
Target release
I would like my code to appear in release V2.10
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests