Skip to content

Fix varchar size #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebuzz merged 3 commits into from
Oct 21, 2025
Merged

Fix varchar size #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d52a1db
fix(LabelTranslation): extend language column to support longer local…
stonebuzz Oct 21, 2025
2b8418d
adapt changelog
stonebuzz Oct 21, 2025
8b9c07a
remove useless empty lines
stonebuzz Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).


## ['UNRELEASED']
## [UNRELEASED]

### Fixed

- Increased the maximum length of the language column to support longer locale codes

## [1.22.1] - 2025-10-10

Expand Down
6 changes: 5 additions & 1 deletion inc/labeltranslation.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public static function installBaseData(Migration $migration, $version)
`id` INT {$default_key_sign} NOT NULL auto_increment,
`itemtype` VARCHAR(30) NOT NULL,
`items_id` INT {$default_key_sign} NOT NULL,
`language` VARCHAR(5) NOT NULL,
`language` VARCHAR(10) NOT NULL,
`label` VARCHAR(255) DEFAULT NULL,
PRIMARY KEY (`id`),
KEY `itemtype` (`itemtype`),
Expand All @@ -90,6 +90,10 @@ public static function installBaseData(Migration $migration, $version)
$migration->addKey($table, 'items_id');
}

if ($DB->fieldExists($table, 'language')) {
$migration->changeField($table, 'language', 'language', "VARCHAR(10) NOT NULL");
}

return true;
}

Expand Down