Skip to content

feat: Enhanced children validation #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zharinov merged 5 commits into from
Dec 6, 2025
Merged

feat: Enhanced children validation #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
05cbb53
feat: Non-field children validation
zharinov Dec 6, 2025
4948b10
Improve diagnostic range reporting for type errors
zharinov Dec 6, 2025
d9b602f
Refactor query validation to improve type checking and error reporting
zharinov Dec 6, 2025
927060c
Follow refs during query validation
zharinov Dec 6, 2025
0cc7e52
Improve recursive references and validation cycle detection
zharinov Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/plotnik-lib/src/diagnostics/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ pub enum DiagnosticKind {
UnknownField,
FieldNotOnNodeType,
InvalidFieldChildType,
InvalidChildType,

// Often consequences of earlier errors
UnnamedDefNotLast,
Expand Down Expand Up @@ -168,6 +169,7 @@ impl DiagnosticKind {
Self::UnknownField => "unknown field",
Self::FieldNotOnNodeType => "field not valid on this node type",
Self::InvalidFieldChildType => "node type not valid for this field",
Self::InvalidChildType => "node type not valid as child",

// Structural
Self::UnnamedDefNotLast => "only the last definition can be unnamed",
Expand All @@ -194,6 +196,7 @@ impl DiagnosticKind {
Self::UnknownField => "`{}` is not a valid field".to_string(),
Self::FieldNotOnNodeType => "field `{}` is not valid on this node type".to_string(),
Self::InvalidFieldChildType => "node type `{}` is not valid for this field".to_string(),
Self::InvalidChildType => "`{}` cannot be a child of this node".to_string(),

// Recursion with cycle path
Self::RecursionNoEscape => "infinite recursion: {}".to_string(),
Expand Down
Loading