Skip to content

fix: Sort diagnostics by source range #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zharinov merged 1 commit into from
Dec 6, 2025
Merged

fix: Sort diagnostics by source range #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/plotnik-lib/src/diagnostics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,15 @@ impl Diagnostics {
}
}

self.messages
let mut result: Vec<_> = self
.messages
.iter()
.enumerate()
.filter(|(i, _)| !suppressed[*i])
.map(|(_, m)| m.clone())
.collect()
.collect();
result.sort_by_key(|m| m.range.start());
result
}

/// Raw access to all diagnostics (for debugging/testing).
Expand Down
8 changes: 4 additions & 4 deletions crates/plotnik-lib/src/query/mod_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ fn combined_errors() {
let q = Query::try_from("(call (Undefined) extra)").unwrap();
assert!(!q.is_valid());
insta::assert_snapshot!(q.dump_diagnostics(), @r"
error: bare identifier is not a valid expression; wrap in parentheses: `(identifier)`
error: `Undefined` is not defined
|
1 | (call (Undefined) extra)
| ^^^^^
| ^^^^^^^^^

error: `Undefined` is not defined
error: bare identifier is not a valid expression; wrap in parentheses: `(identifier)`
|
1 | (call (Undefined) extra)
| ^^^^^^^^^
| ^^^^^
");
}