feat: Add prefix-collapse optimization for alternation branches #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge structurally identical successor instructions into one with combined successors. Reduces instruction count for patterns like `[(object ...) (object ...)]`. Also fixes collapse_up to count predecessors before removing shared labels.
zharinov
force-pushed
the
feat/prefix-collapse
branch
from
58e6926 to
3d17552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
collapse_upto count predecessors before removing shared labelsWhy
Patterns like
[(object (pair)) (object (string))]generate duplicate(object)instructions that differ only in successors. This pass merges them, reducing instruction count.Notes
Not a frequent optimization trigger, but reduces bytecode size when it applies.