refactor: Change bytecode to distinguish named and anonymous nodes #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zharinov
force-pushed
the
refactor/node-type-ir
branch
4 times, most recently
from
13f519b to
e69571f
Compare
- Add Nav::Epsilon variant for epsilon transitions - Add NodeTypeIR enum to distinguish Any/Named/Anonymous node constraints - Epsilon transitions no longer show `_` pattern (no node interaction) - Add trace_nav_failure to show failed navigation attempts - Update bytecode header to 2+2+4 bit layout
zharinov
force-pushed
the
refactor/node-type-ir
branch
from
e69571f to
e242e52
Compare
zharinov
changed the title
Nav::Epsilon and NodeTypeIR enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nav::Epsilonvariant for epsilon transitions (replaces implicit detection via 3 conditions)NodeTypeIRenum to distinguishAny/Named/Anonymousnode constraints in Match instructionsWhy
Epsilon transitions were detected implicitly by checking
nav == Stay && node_type == 0 && node_field.is_none(). This was fragile and spread across multiple locations. ExplicitNav::Epsilonmakes the intent clear and simplifiesis_epsilon()to a single comparison.Similarly, node type constraints conflated "any node" (
_), "any named node" ((_)), and "specific type" into a singleu16field using magic values.NodeTypeIRmakes the three cases explicit and enables proper handling of anonymous nodes ("text"literals).