Skip to content

refactor: extract parse_quantifier helper to reduce duplication #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zharinov merged 1 commit into from
Jan 4, 2026
Merged

refactor: extract parse_quantifier helper to reduce duplication #242

zharinov merged 1 commit into from
Jan 4, 2026

Conversation

@zharinov
Copy link
Member

@zharinov zharinov commented Jan 4, 2026

Summary

  • Adds QuantifierParse enum and parse_quantifier() helper to consolidate repeated "unwrap quantifier → inner/op/kind" pattern
  • Refactors 4 call sites: compile_quantified_inner, compile_quantified_for_array, compile_skippable_with_exits, compile_star_for_array_with_exits
  • Reduces ~40 lines of duplicated early-return boilerplate

@zharinov zharinov enabled auto-merge (squash) January 4, 2026 03:57
@zharinov zharinov merged commit f162517 into master Jan 4, 2026
4 checks passed
@zharinov zharinov deleted the refactor/parse-quantifier branch January 4, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zharinov