Skip to content

feat: Add semicolon as line comment delimiter #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zharinov merged 1 commit into from
Dec 27, 2025
Merged

feat: Add semicolon as line comment delimiter #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/plotnik-lib/src/parser/cst.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ pub enum SyntaxKind {
Newline,

#[regex(r"//[^\n]*", allow_greedy = true)]
#[regex(r";[^\n]*", allow_greedy = true)]
LineComment,

#[regex(r"/\*(?:[^*]|\*[^/])*\*/")]
Expand Down
26 changes: 26 additions & 0 deletions crates/plotnik-lib/src/parser/tests/grammar/trivia_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,3 +182,29 @@ fn comment_only_raw() {
Newline "\n"
"#);
}

#[test]
fn semicolon_comment() {
let input = indoc! {r#"
; semicolon comment
Q = (identifier)
"#};

let res = Query::expect_valid_cst_full(input);

insta::assert_snapshot!(res, @r#"
Root
LineComment "; semicolon comment"
Newline "\n"
Def
Id "Q"
Whitespace " "
Equals "="
Whitespace " "
Tree
ParenOpen "("
Id "identifier"
ParenClose ")"
Newline "\n"
"#);
}