Skip to content

refactor: Avoid node clones on casting #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zharinov merged 1 commit into from
Dec 16, 2025
Merged

refactor: Avoid node clones on casting #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/plotnik-lib/src/parser/ast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ macro_rules! ast_node {

impl $name {
pub fn cast(node: SyntaxNode) -> Option<Self> {
(node.kind() == SyntaxKind::$kind).then(|| Self(node))
Self::can_cast(node.kind()).then(|| Self(node))
}

pub fn can_cast(kind: SyntaxKind) -> bool {
kind == SyntaxKind::$kind
}

pub fn as_cst(&self) -> &SyntaxNode {
Expand All @@ -54,7 +58,8 @@ macro_rules! define_expr {

impl Expr {
pub fn cast(node: SyntaxNode) -> Option<Self> {
$(if let Some(n) = $variant::cast(node.clone()) { return Some(Expr::$variant(n)); })+
let kind = node.kind();
$(if $variant::can_cast(kind) { return Some(Expr::$variant($variant(node))); })+
None
}

Expand Down Expand Up @@ -138,7 +143,11 @@ pub struct AnonymousNode(SyntaxNode);

impl AnonymousNode {
pub fn cast(node: SyntaxNode) -> Option<Self> {
matches!(node.kind(), SyntaxKind::Str | SyntaxKind::Wildcard).then(|| Self(node))
Self::can_cast(node.kind()).then(|| Self(node))
}

pub fn can_cast(kind: SyntaxKind) -> bool {
matches!(kind, SyntaxKind::Str | SyntaxKind::Wildcard)
}

pub fn as_cst(&self) -> &SyntaxNode {
Expand Down