Fix errors in Route53 provider#8
Open
amiryal wants to merge 3 commits intoploperations:revert-10-remove_r53from
Open
Fix errors in Route53 provider#8amiryal wants to merge 3 commits intoploperations:revert-10-remove_r53from
amiryal wants to merge 3 commits intoploperations:revert-10-remove_r53from
Conversation
* Use .all! instead of .all, to really get beyond the first batch.
* Use .chomp('.') and .to_s where necessary to compare values correctly.
* Add a check for r.type == resource[:type], to avoid destroying innocent records.
* Add mk_resource_methods, because Puppet was throwing exceptions otherwise.
* Use info level message when performing a destructive action. * Emit messages before attempting the action, so that exceptions appear in context in the logs. * Remove references to unused resource property `domain`. * Add a few more debug messages.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I stumbled upon a bug in the
route53provider, where managed records kept being destroyed and re-created on every Puppet run, even though they were correct in the actual DNS zone. This PR contains the fix that works for me.I split the patch into several commits: one cosmetic, one for the actual fix, and one with the changes in debug/info messages that helped me identify the problem.