Skip to content

SVG scaling when no width/height attributes are available#120

Merged
petschki merged 4 commits intomasterfrom
issue-119
Feb 10, 2026
Merged

SVG scaling when no width/height attributes are available#120
petschki merged 4 commits intomasterfrom
issue-119

Conversation

@petschki
Copy link
Member

@petschki petschki commented Sep 1, 2025

fixes #119

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

petschki commented Sep 1, 2025

@jenkins-plone-org please run jobs

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the data is unchanged, it would be nice if we could store a reference to the original blob instead of copying the data.

@petschki petschki changed the title SVG scaling when not width/height attributes are available SVG scaling when no width/height attributes are available Jan 26, 2026
@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki petschki requested a review from davisagli January 26, 2026 14:28
@petschki petschki merged commit cb6d760 into master Feb 10, 2026
12 checks passed
@petschki petschki deleted the issue-119 branch February 10, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVG: image cannot render when no source_width/height is available

3 participants