Skip to content

Added is_multilingual to @site endpoint#1884

Merged
davisagli merged 4 commits intomainfrom
enhancesiteendpoint
Mar 9, 2025
Merged

Added is_multilingual to @site endpoint#1884
davisagli merged 4 commits intomainfrom
enhancesiteendpoint

Conversation

@sneridagh
Copy link
Member

@sneridagh sneridagh commented Mar 8, 2025


📚 Documentation preview 📚: https://plonerestapi--1884.org.readthedocs.build/

@sneridagh sneridagh requested review from davisagli and erral March 8, 2025 11:32
@mister-roboto
Copy link

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@sneridagh sneridagh changed the title Added is_multilingual to @site endpoint Added is_multilingual to @site endpoint Mar 8, 2025
@sneridagh
Copy link
Member Author

@davisagli the builds are failing for 6.0, no clue why :( Same happens locally.

I still have to add the documentation updates.
I guess you have it already in mind, but the auto documentation generator is still pointing for using 6.0, and the Makefile command is missing for 6.1.

I added some comments, I had doubts, doing it inline.

@davisagli davisagli merged commit adbc852 into main Mar 9, 2025
16 of 22 checks passed
@davisagli davisagli deleted the enhancesiteendpoint branch March 9, 2025 22:29
@sneridagh
Copy link
Member Author

Thanks @davisagli ! It would be great to have a release soon, so we can continue with Volto's related PR. I think @mauritsvanrees is thinking in cutting a Plone one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants