Skip to content

fix tests for new image sizes attribute #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrTango wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix tests for new image sizes attribute #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51140f9
fix tests for new image sizes attribute
MrTango Apr 22, 2025
a9e78bd
Merge branch 'master' into mrtango-image-sizes
MrTango Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/180.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
allow sizes attribute in picture tags, see https://github.com/plone/plone.namedfile/pull/180
[MrTango]
8 changes: 4 additions & 4 deletions plone/outputfilters/tests/test_picture_variants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def test_parsing_long_doc(self):
<p class="discreet">
<picture>
<source
srcset="resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w"/>
sizes="(min-width: 576px) 400px, (min-width: 768px) 600px, 98vw" srcset="resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w"/>
<img alt="" class="image-richtext image-inline image-size-small" data-linktype="image"
data-picturevariant="small" data-scale="preview" data-val="{uid}" loading="lazy"
src="resolveuid/{uid}/@@images/image/preview"/>
Expand All @@ -190,7 +190,7 @@ def test_parsing_long_doc(self):
<p>
<picture class="captioned">
<source
srcset="resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/great 1200w"/>
sizes="(min-width: 576px) 600px, 98vw" srcset="resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/great 1200w"/>
<img alt="" class="image-richtext image-left image-size-medium captioned zoomable" data-linktype="image"
data-picturevariant="medium" data-scale="larger" data-val="{uid}" loading="lazy"
src="resolveuid/{uid}/@@images/image/teaser"/>
Expand All @@ -205,7 +205,7 @@ def test_parsing_long_doc(self):
<p class="discreet">
<picture>
<source
srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
sizes="(min-width: 576px) 1000px, 98vw" srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
<img alt="" class="image-richtext image-right image-size-large" data-linktype="image"
data-picturevariant="large" data-scale="huge" data-val="{uid}" loading="lazy"
src="resolveuid/{uid}/@@images/image/larger"/>
Expand All @@ -216,7 +216,7 @@ def test_parsing_long_doc(self):
<h2>
<picture>
<source
srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
sizes="(min-width: 576px) 1000px, 98vw" srcset="resolveuid/{uid}/@@images/image/larger 1000w, resolveuid/{uid}/@@images/image/preview 400w, resolveuid/{uid}/@@images/image/teaser 600w, resolveuid/{uid}/@@images/image/large 800w, resolveuid/{uid}/@@images/image/great 1200w, resolveuid/{uid}/@@images/image/huge 1600w"/>
<img alt="" class="image-richtext image-inline image-size-large" data-linktype="image"
data-picturevariant="large" data-scale="huge" data-val="{uid}" loading="lazy"
src="resolveuid/{uid}/@@images/image/larger"/>
Expand Down
Loading