Skip to content

Add original scale's url in srcset (main)#197

Merged
erral merged 4 commits intomainfrom
erral-add-original-scale-url-in-srcset
Mar 5, 2026
Merged

Add original scale's url in srcset (main)#197
erral merged 4 commits intomainfrom
erral-add-original-scale-url-in-srcset

Conversation

@erral
Copy link
Member

@erral erral commented Feb 26, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

Like #196 for main

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral erral requested a review from libargutxi February 26, 2026 11:20
@erral
Copy link
Member Author

erral commented Feb 26, 2026

@jenkins-plone-org please run jobs

@davisagli
Copy link
Member

I'm intentionally not reviewing this one since it's mostly for Classic UI which I'm not working with closely these days. @plone/classicui-team?

@erral
Copy link
Member Author

erral commented Mar 5, 2026

Thanks David, I was assuming that :)

@erral erral merged commit 4da0fcc into main Mar 5, 2026
11 checks passed
@erral erral deleted the erral-add-original-scale-url-in-srcset branch March 5, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants