Conversation
|
@erral thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
Thanks for tackling this!
4 participants
I have configured this package with plone/meta because when running the tests of #170 some tests failed with the following error
pkg_resources.DistributionNotFound: The 'plone.namedfile' distribution was not found and is required by plone.app.users, plone.outputfilters, plone.app.vocabulariesand I thought that this could be because of the setuptools thing :/
But now I don't feel confident enough to touch package dependencies (last time I did something similar in a package of the collective we had a lengthy discussion with dependency declaration), so now I am a bit lost :(I managed to add the dependencies!