Skip to content

Draft: Use catalog's getpath method instead of internals #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davisagli wants to merge 1 commit into from
Closed

Draft: Use catalog's getpath method instead of internals #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/plone/folder/nogopip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,13 @@ def documentToKeyMap(self):
# results themselves. luckily this is only ever called from
# `sortResults`, so we can get it form there. oh, and lurker
# says this won't work in jython, though! :)
rs = currentframe().f_back.f_locals["rs"]
caller_locals = currentframe().f_back.f_locals
catalog = caller_locals["self"].aq_parent
rs = caller_locals["rs"]
rids = {}
items = []
containers = {}
getpath = self.catalog.paths.get
getpath = catalog.getpath
root = getUtility(ISiteRoot).getPhysicalRoot()
for rid in rs:
path = getpath(rid)
Expand Down
3 changes: 0 additions & 3 deletions src/plone/folder/ordered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,6 @@ def manage_renameObject(self, id, new_id, REQUEST=None):
if old_position is None:
return result
self.moveObjectToPosition(new_id, old_position, suppress_events=True)
reindex = getattr(self._getOb(new_id), "reindexObject", None)
if reindex is not None:
reindex(idxs=["getObjPositionInParent"])
return result

# Dict interface
Expand Down