Skip to content

Fix issues with dependencychecker and current setuptools.#108

Merged
davisagli merged 2 commits intomainfrom
thet/fix-dependencychecker-failure
Feb 20, 2026
Merged

Fix issues with dependencychecker and current setuptools.#108
davisagli merged 2 commits intomainfrom
thet/fix-dependencychecker-failure

Conversation

@thet
Copy link
Member

@thet thet commented Feb 19, 2026

Ref: reinout/z3c.dependencychecker#119

Tryout if this fixes probs with tox.

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral

This comment was marked as outdated.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tox.ini is generated by plone/meta. This was already fixed in plone/meta (plone/meta#321) so reapplying plone/meta to this package should fix it in the standard way.

@thet thet force-pushed the thet/fix-dependencychecker-failure branch from d03188b to 6199787 Compare February 20, 2026 11:22
@thet
Copy link
Member Author

thet commented Feb 20, 2026

Right, plone.meta again.
Reconfigured it with plone.meta, but kept my commit log as it points to the original problem.

@thet thet requested a review from davisagli February 20, 2026 11:23
(since it's a fix for dev tooling, not relevant to users of the package)
@davisagli davisagli merged commit 119685f into main Feb 20, 2026
10 of 12 checks passed
@davisagli davisagli deleted the thet/fix-dependencychecker-failure branch February 20, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants