Skip to content

Do not test the value of useRemoteUrl in the navigation portlet. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensens merged 1 commit into from
Feb 14, 2026
Merged

Do not test the value of useRemoteUrl in the navigation portlet. #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions news/4269.tests.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Do not test the value of ``useRemoteUrl`` in the navigation portlet.
We no longer want to use this.
[maurits]
14 changes: 0 additions & 14 deletions src/plone/app/portlets/tests/test_navigation_portlet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,20 +213,6 @@ def testCreateNavTreeWithLink(self):
self.assertFalse(child["getRemoteUrl"])
if child["Title"] == "link1":
self.assertEqual(child["getRemoteUrl"], "http://plone.org")
# as Creator, link1 should not use the remote Url
self.assertFalse(child["useRemoteUrl"])

self.portal.link1.setCreators(["some_other_user"])
self.portal.link1.reindexObject()
view = self.renderer(self.portal)
tree = view.getNavTree()
for child in tree["children"]:
if child["portal_type"] != "Link":
self.assertFalse(child["getRemoteUrl"])
if child["Title"] == "link1":
self.assertEqual(child["getRemoteUrl"], "http://plone.org")
# as non-Creator user, link1 should use the remote Url
self.assertTrue(child["useRemoteUrl"])

def testNonStructuralFolderHidesChildren(self):
# Make sure NonStructuralFolders act as if parent_types_not_to_query
Expand Down