Conversation
context: the start and end values are later checked against datetime objects in the expand_events,which broke due to the passed DateTime and String formats (depending on the query)
context: event_listing didn't always show the results from the collection.
|
@ThibautBorn thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
context: make code more readable by seperating usecases
|
@ThibautBorn please let us know if you are stuck and need some help figuring out how to proceed. Three checks fail. |
|
I'm going to keep working on this, it's just very busy at the moment. Thank you for the offer to help! |
3 participants
Trying to improve the event_listing view. Which breaks or doesn't give the expected results when using the start/end date query in collections