Skip to content

Pass request as context parameter in the translate function (branch 5.x)#300

Merged
erral merged 4 commits into5.xfrom
erral-translation-fixes-branch-5
Feb 18, 2026
Merged

Pass request as context parameter in the translate function (branch 5.x)#300
erral merged 4 commits into5.xfrom
erral-translation-fixes-branch-5

Conversation

@erral
Copy link
Member

@erral erral commented Feb 17, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

We are using translate function and passing a message object, but if we do not pass the request as context, it will never translate those messages.

Merge after #299

Supercedes #297 because I can't force-push to it because of the branch protection rules.

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral erral changed the base branch from main to 5.x February 17, 2026 07:30
@erral
Copy link
Member Author

erral commented Feb 17, 2026

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Feb 18, 2026

@jenkins-plone-org please run jobs

@erral erral merged commit 6ff37e4 into 5.x Feb 18, 2026
7 checks passed
@erral erral deleted the erral-translation-fixes-branch-5 branch February 18, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants