Skip to content

Pass request as context parameter in the translate function (main branch)#298

Merged
erral merged 4 commits intomainfrom
erral-translation-fixes-main
Mar 5, 2026
Merged

Pass request as context parameter in the translate function (main branch)#298
erral merged 4 commits intomainfrom
erral-translation-fixes-main

Conversation

@erral
Copy link
Member

@erral erral commented Feb 16, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

We are using the translate function and passing a message object, but if we do not pass the request as context, it will never translate those messages

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Feb 16, 2026

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Feb 16, 2026

The dependency checker problem is because z3c.dependencychecker relies on pkg_resources and hasn't been updated yet. See: https://community.plone.org/t/z3c-dependencychecker-throw-an-error-no-module-named-pkg-resources/22830

@erral
Copy link
Member Author

erral commented Feb 16, 2026

@jenkins-plone-org please run jobs

Co-authored-by: David Glick <david@glicksoftware.com>
@erral
Copy link
Member Author

erral commented Feb 17, 2026

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Feb 20, 2026

Reapplied plone/meta to have the dependencychecker error gone.

@erral
Copy link
Member Author

erral commented Feb 20, 2026

@jenkins-plone-org please run jobs

@erral erral merged commit 796bbd8 into main Mar 5, 2026
12 checks passed
@erral erral deleted the erral-translation-fixes-main branch March 5, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants