Fixes duplicate form while replying to Comment#267
Conversation
|
@rohnsha0 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
rohnsha0
changed the title
| </div> | ||
|
|
||
| <!-- JavaScript to handle dynamic form label updates --> | ||
| <script type="text/javascript"> |
There was a problem hiding this comment.
We should update the code in https://github.com/plone/mockup/blob/master/src/pat/controlpanels/discussion-comments--implementation.js (then release it in plone.staticresources), not add a script to every page that uses comments.
There was a problem hiding this comment.
@davisagli I am unable to test out changes made in mockup repo locally using buildout.coredev... I have already implemented some fix but unable to test it out
Is there some other docs to test the changes?!
There was a problem hiding this comment.
@rohnsha0 I am not up to date on the current processes for developing javascript for Classic UI, since I'm only working on Volto sites these days.
There is some information in https://github.com/plone/plone.staticresources?tab=readme-ov-file#how-to-upgrade-the-resources-in-this-package (which is where the mockup scripts are built and released to be used in Plone) and in https://github.com/plone/mockup?tab=readme-ov-file#development
If you have questions maybe @thet or @petschki can help, or ask in the Classic UI channel on Discord.
There was a problem hiding this comment.
@davisagli I am unable to test out changes made in
mockuprepo locally usingbuildout.coredev... I have already implemented some fix but unable to test it outIs there some other docs to test the changes?!
@rohnsha0 to test local mockup changes please check out the Development section of the readme: https://github.com/plone/mockup?tab=readme-ov-file#development ... feel free to contact me on discord if you need help.
| init(); | ||
| } | ||
| })(); | ||
| </script> |
There was a problem hiding this comment.
This sounds like a perfect task for pat-inject which is shipped with Classic-UI ... see its documentation here: https://patternslib.com/demos/inject
4 participants
fixes #88
