Use fork of grunt-sed #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
To make testing this package even more funny travis fails to run (while it has been working fine) and jenkins starts working (which was failing up to now). |
gforcada
force-pushed
the
gforcada-remove-grunt-sed
branch
2 times, most recently
from
b149aab to
e4010a2
Compare
As the maintainer seems to not be so much responsive, use a fork of it directly from github that has fixed the dependencies problem.
gforcada
force-pushed
the
gforcada-remove-grunt-sed
branch
from
e4010a2 to
e0845c0
Compare
Member
|
please do this version fix and any necessary changes also in: https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/_scripts/compile_resources.py#L20 after that, and if tests go green for jenkins, this should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So seems that grunt-sed is used in quite some places, so it can not be removed as my original idea was.
Fortunately there is a pull request to fix the dependency problems jharding/grunt-sed#17 and npm allows to define versions as github URLs (even so short that you don't need to say that they come from github).
Long story short: I forked the pull request's fork on collective (just to prevent that the fork removes the commits) so now jenkins and travis both run fine :-)