Skip to content

[WIP] Use the translated review_state title#1001

Closed
erral wants to merge 1 commit intomasterfrom
erral-fc
Closed

[WIP] Use the translated review_state title#1001
erral wants to merge 1 commit intomasterfrom
erral-fc

Conversation

@erral
Copy link
Member

@erral erral commented Jul 8, 2020

Merge together with plone/plone.app.content#207

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@thet
Copy link
Member

thet commented Oct 9, 2020

@erral what's the state here?
sounds like a useful feature!

@thet thet changed the title Use the translated review_state title [WIP] Use the translated review_state title Oct 9, 2020
@erral
Copy link
Member Author

erral commented Oct 9, 2020

It is a proof of concept and needs more work and more testing.

@MrTango
Copy link
Contributor

MrTango commented Jan 12, 2022

If this should be shipped with Plone 6 it needs to be finshed soon.
We want to fix the test now and merge into master soon.
But it can also be merged into master later, as long as we are not in Plone 6 beta.

@erral
Copy link
Member Author

erral commented Jan 12, 2022

I would like to but I have no time to look at this in the coming weeks.

@petschki
Copy link
Member

fixed with #1248

@petschki petschki closed this Nov 29, 2022
@erral erral deleted the erral-fc branch November 30, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants