Skip to content

Conversation

@erral
Copy link
Member

@erral erral commented Dec 12, 2025

@erral erral changed the title document the changes in p.a.multilingual regarding translation services and Google TRanslate. document the changes in p.a.multilingual regarding translation services and Google Translate. Dec 12, 2025
@stevepiercy stevepiercy moved this from New to In Progress in Plone Documentation Dec 14, 2025
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Mostly just a few MyST markup, style, and grammar suggestions.

erral and others added 12 commits December 14, 2025 14:24
…2..md

Co-authored-by: Steve Piercy <web@stevepiercy.com>
…2..md

Co-authored-by: Steve Piercy <web@stevepiercy.com>
…2..md

Co-authored-by: Steve Piercy <web@stevepiercy.com>
…2..md

Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the discussion in plone/Products.CMFPlone#4244, I revised this section to provide more detail and clarification. @rohnsha0 @erral @mamico I'd appreciate your thoughts on this suggestion. Thank you!

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix this one.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made another pass, and found a few more things.

Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral one final question. Please let me know. Thank you!

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe now?

@stevepiercy
Copy link
Contributor

Yay! Merging. Thank you @erral!

Screenshot 2025-12-15 at 2 55 11 AM

@stevepiercy stevepiercy merged commit 707b149 into 6.0 Dec 15, 2025
3 checks passed
@stevepiercy stevepiercy deleted the erral-external-translations branch December 15, 2025 10:57
@github-project-automation github-project-automation bot moved this from In Progress to Done in Plone Documentation Dec 15, 2025
@erral
Copy link
Member Author

erral commented Dec 15, 2025

Sorry @stevepiercy the PLIP has not been approved yet, and the other PRs are not merged yet. We better revert the changes until everything is in place, right?

@stevepiercy
Copy link
Contributor

Sorry @stevepiercy the PLIP has not been approved yet, and the other PRs are not merged yet. We better revert the changes until everything is in place, right?

Well... how about let's wait and see? No one's upgrading to Plone 6.2 right now anyway, so why undo something now that might be fine in the long run?

If someone wants to submit a PR to go through that dance, I'll merge it.

In the future, please mark PRs as Draft if they shouldn't be merged or reviewed.

@davisagli
Copy link
Member

@stevepiercy You merged a PR for docs that had no technical review yet, covering a PLIP that was submitted a few days ago and hasn't yet been seconded. Who knows if it will end up in Plone 6.2 or 6.3. It's premature for this to be in the published docs. Please revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants