-
-
Notifications
You must be signed in to change notification settings - Fork 186
document the changes in p.a.multilingual regarding translation services and Google Translate. #2003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Mostly just a few MyST markup, style, and grammar suggestions.
docs/backend/upgrading/version-specific-migration/upgrade-to-62.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-62..md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-62..md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-62..md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-62..md
Outdated
Show resolved
Hide resolved
…2..md Co-authored-by: Steve Piercy <web@stevepiercy.com>
…2..md Co-authored-by: Steve Piercy <web@stevepiercy.com>
…2..md Co-authored-by: Steve Piercy <web@stevepiercy.com>
…2..md Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the discussion in plone/Products.CMFPlone#4244, I revised this section to provide more detail and clarification. @rohnsha0 @erral @mamico I'd appreciate your thoughts on this suggestion. Thank you!
docs/backend/upgrading/version-specific-migration/upgrade-to-62.md
Outdated
Show resolved
Hide resolved
…2.md Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this one.
docs/backend/upgrading/version-specific-migration/upgrade-to-62.md
Outdated
Show resolved
Hide resolved
|
I'll double-check the page renderings at: |
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made another pass, and found a few more things.
docs/backend/upgrading/version-specific-migration/upgrade-to-62.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-62.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-62.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Piercy <web@stevepiercy.com>
docs/backend/upgrading/version-specific-migration/upgrade-to-62.md
Outdated
Show resolved
Hide resolved
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erral one final question. Please let me know. Thank you!
Co-authored-by: Steve Piercy <web@stevepiercy.com>
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe now?
|
Yay! Merging. Thank you @erral!
|
|
Sorry @stevepiercy the PLIP has not been approved yet, and the other PRs are not merged yet. We better revert the changes until everything is in place, right? |
Well... how about let's wait and see? No one's upgrading to Plone 6.2 right now anyway, so why undo something now that might be fine in the long run? If someone wants to submit a PR to go through that dance, I'll merge it. In the future, please mark PRs as Draft if they shouldn't be merged or reviewed. |
|
@stevepiercy You merged a PR for docs that had no technical review yet, covering a PLIP that was submitted a few days ago and hasn't yet been seconded. Who knows if it will end up in Plone 6.2 or 6.3. It's premature for this to be in the published docs. Please revert. |

Part of plone/Products.CMFPlone#4244
📚 Documentation preview 📚: https://plone6--2003.org.readthedocs.build/