Skip to content

Fix deprecated pattern_settings call#4286

Merged
thet merged 2 commits intomasterfrom
fix-deprecated-patternsettings
Mar 4, 2026
Merged

Fix deprecated pattern_settings call#4286
thet merged 2 commits intomasterfrom
fix-deprecated-patternsettings

Conversation

@petschki
Copy link
Member

@petschki petschki commented Mar 3, 2026

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

petschki commented Mar 3, 2026

@jenkins-plone-org please run jobs

@petschki petschki requested a review from thet March 3, 2026 13:46
@thet thet merged commit eea2367 into master Mar 4, 2026
10 checks passed
@thet thet deleted the fix-deprecated-patternsettings branch March 4, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants