Skip to content

Python 3.14 testing matrix, trove classifiers.#4285

Open
thet wants to merge 4 commits intomasterfrom
thet/py314
Open

Python 3.14 testing matrix, trove classifiers.#4285
thet wants to merge 4 commits intomasterfrom
thet/py314

Conversation

@thet
Copy link
Member

@thet thet commented Feb 27, 2026

Updated with the branch from: plone/meta#330

@mister-roboto
Copy link

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@thet
Copy link
Member Author

thet commented Mar 9, 2026

I'm not sure, if we should consider this for merging or better try to restore the old black behavior (I did like two newlines after the imports...) or even switch to ruff for a all-in-one solution.

@gforcada
Copy link
Member

I did like the 2 lines as well, but I prefer to not have to fight the tooling and just accept what it comes from them 😅

If we switch to ruff... there is a PR for that on plone.meta, so we might do that indeed.

@thet
Copy link
Member Author

thet commented Mar 10, 2026

@gforcada tnx for checking!

I wanted to know if ruff has a different opinion on the two newlines after the imports, so I also ran ruff on the codebase. Ruff has the same opinion on that, but finds a bunch more problems - e.g. from an earlier formatting occurrences of multi-line string concatenations re-combined on one line like:
"hello " "gil!"
which ruff changed to
"hello gil!".
I re-ran black via pre-commit after ruff to make sure not to apply any changes which black would change again and this is my PR update.

@gforcada please re-check!

@thet
Copy link
Member Author

thet commented Mar 10, 2026

@jenkins-plone-org please run jobs

@thet thet requested a review from gforcada March 10, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants