Conversation
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
I'm not sure, if we should consider this for merging or better try to restore the old |
|
I did like the 2 lines as well, but I prefer to not have to fight the tooling and just accept what it comes from them 😅 If we switch to ruff... there is a PR for that on |
|
@gforcada tnx for checking! I wanted to know if ruff has a different opinion on the two newlines after the imports, so I also ran ruff on the codebase. Ruff has the same opinion on that, but finds a bunch more problems - e.g. from an earlier formatting occurrences of multi-line string concatenations re-combined on one line like: @gforcada please re-check! |
|
@jenkins-plone-org please run jobs |
Updated with the branch from: plone/meta#330