Improve the performance of the "find" function from the Union-Find Data Structure#82
Open
ZhongxuanWang wants to merge 1 commit intopllk:masterfrom
Open
Improve the performance of the "find" function from the Union-Find Data Structure#82ZhongxuanWang wants to merge 1 commit intopllk:masterfrom
ZhongxuanWang wants to merge 1 commit intopllk:masterfrom
Conversation
|
I think this change implements path compression, which is quite reasonable to have. I would suggest implementing it using a loop, though. Otherwise, it's totally possible to catch a stack overflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old implementation is defective and the program will spend much more time in searching for the root. However with the new recursive implementation, after finding out the root the root index is stored in the starting point, which will reduce the number of paths they will have to go, improving the running time a lot.