Added HD Audio support (currently only TrueHD)#283
Open
irond13 wants to merge 1 commit intoplexinc:developfrom
Open
Added HD Audio support (currently only TrueHD)#283irond13 wants to merge 1 commit intoplexinc:developfrom
irond13 wants to merge 1 commit intoplexinc:developfrom
Conversation
ruuk
approved these changes
May 25, 2020
Contributor
ruuk
left a comment
ruuk
left a comment
There was a problem hiding this comment.
Thanks for the PR. Everything looks good. I've been meaning to change to the Generic profile and fix up the augmentations, and that will need to be done before this can be merged. I'm approving this now. I'll merge it when I can get a chance to do the follow up work to support Generic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHI (If applicable): #
Description:
This seeks to enable support for HD audio direct streaming when transcoding video.
It may not be possible to merge this in without amendments due to the change in X-Plex-Platform, however the default Chrome profile doesn't allow audio above 2 channels.
Checklist: