seekdialog: skip user input while changing qualities#249
Open
pannal wants to merge 2 commits intoplexinc:developfrom
Open
seekdialog: skip user input while changing qualities#249pannal wants to merge 2 commits intoplexinc:developfrom
pannal wants to merge 2 commits intoplexinc:developfrom
Conversation
pannal
force-pushed
the
pr_quality_change_skip_input
branch
from
5ac252c to
7de8083
Compare
ruuk
reviewed
Sep 26, 2018
pannal
force-pushed
the
pr_quality_change_skip_input
branch
from
00efc8e to
a1c92a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHI (If applicable): #
Description:
Ignores user input while switching qualities mid-playback. Depending on the speed of the server and/or client, there's a huge time window where user input shouldn't be considered.
Checklist: