Show mark unplayed even if video in progress#228
Open
pannal wants to merge 1 commit intoplexinc:developfrom
Open
Show mark unplayed even if video in progress#228pannal wants to merge 1 commit intoplexinc:developfrom
pannal wants to merge 1 commit intoplexinc:developfrom
Conversation
pannal
force-pushed
the
pr_progress_unplayed
branch
from
8801659 to
382036f
Compare
ruuk
reviewed
Jul 20, 2018
| inProgress = mli.dataSource.viewOffset.asInt() | ||
| if not mli.dataSource.isWatched or inProgress: | ||
| options.append({'key': 'mark_watched', 'display': T(32319, 'Mark Played')}) | ||
| if mli.dataSource.isWatched or inProgress: |
Contributor
There was a problem hiding this comment.
This should just be an else:
The correct behavior for an item that is unplayed or played but in progress is to mark watched - otherwise mark unwatched.
Contributor
Author
There was a problem hiding this comment.
Hm no, that's what this PR is about. PlexWeb now shows both Mark Played/Unplayed for in progress items (which makes sense).
Contributor
Author
There was a problem hiding this comment.
(and it's always bugged me that that wasn't the case before)
| inProgress = self.video.viewOffset.asInt() | ||
| if not self.video.isWatched or inProgress: | ||
| options.append({'key': 'mark_watched', 'display': T(32319, 'Mark Played')}) | ||
| if self.video.isWatched or inProgress: |
pannal
changed the title
Contributor
Author
|
Would you agree to this if we made it an advanced setting? |
ruuk
force-pushed
the
develop
branch
2 times, most recently
from
78f9acc to
126aaba
Compare
… even if video in progress
pannal
force-pushed
the
pr_progress_unplayed
branch
from
382036f to
09b2216
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHI (If applicable): #
Description:
Checklist: