Chore: Revamped Package to standard package structure #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@EffanByte please write a description of the changes |
Since the package can now be pulled from git URL, the path has been updated to /Packages/package instead of Assets/Package.
Collaborator
|
Looking good! need to add node_modules.meta to .gitIgnore |
…der on opening project
The window is currently a menu item at the top. Functionalities that currently works are - Refreshing to check node if node works - Setting nodejs file path - Going to the download page Functionality Left to Implement: - Checking for node_modules - Running the install script
Changed file path to be consistent with folder location of git packages
Trying to fix the currently directory for npm install.
…PlayroomKit/Editor
Collaborator
|
Need to move node_modules to Assets/playroom/editor, we will also use this for prefabs which come with the package |
- Automatically refreshes npm manager now after install - Node Modules moved to Assets/Playroom from Packages/Playroom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used Unity's editor to rearrange all of the files into a standard layout given by https://docs.unity3d.com/6000.1/Documentation/Manual/cus-layout.html.
Primary changes include