Skip to content

Conversation

@sugarmanz
Copy link
Member

Since ManagedPlayer callbacks are invoked automatically within PlayerFragment, we should catch runtime released exceptions to protect against app crashes. We would ideally log, but we don't have an active logger yet that isn't dependent upon the runtime

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

@sugarmanz sugarmanz requested a review from a team as a code owner November 25, 2025 22:10
@sugarmanz sugarmanz added the patch Increment the patch version when merged label Nov 25, 2025
is Error -> onError(it)
is Done -> onDone(it)
}
} catch (exception: PlayerRuntimeException) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make that exception "special" and catch only that, instead of all PlayerRuntimeExceptions

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.77%. Comparing base (4161f9e) to head (e5a86fc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         504      504           
  Lines       22679    22679           
  Branches     2651     2651           
=======================================
  Hits        19454    19454           
  Misses       2896     2896           
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants