fix(GSplat): Do not apply instance and material again if no changes.
#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b28c3a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
willeastcott
approved these changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #302 by preventing unnecessary reapplication of instance and material properties on the GSplat component when their values haven't changed.
Key changes:
- Added early return in property setters when values haven't changed to avoid redundant operations
- Added support for
materialandinstanceproperties with proper validation and type checking
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
instancegets reapplied to the PCGSplatproperty value regardless whether the value has changed or not.applyPropsif value has not changed #298 requires a tad bit more work and testing, so we will merge this fix first so that users can work with GSplat properly