Merged
Conversation
Snailprincess
suggested changes
Dec 14, 2016
| } | ||
| queue.length = 0; | ||
| this._elapsed = 0; | ||
| this._isPaused = false; |
Contributor
There was a problem hiding this comment.
Hmm... I wonder if we should update the native core as well.
https://github.com/gameclosure/native-core/blob/9ed8d903d92ffa6e52af32e18540bbee8defed08/timestep/timestep_animate.cpp#L138
That appears to be the equivalent function and it also isn't clearing the paused flag. But I know very little about that code base.
Contributor
Author
|
@Snailprincess I made PR for native core, could you please check: play-co/native-core#15 |
Contributor
|
@AlexTiTanium this looks good, I'm going to merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try call
animate(...).clear()on paused animation, next callanimate(...).pause()won't work.This happens because
clear()doesn't reset paused state for the object.