use getExnternalFilesDir instead of getExternalStorageDirectory#44
Open
jishnu7 wants to merge 4 commits intoplay-co:masterfrom
Open
use getExnternalFilesDir instead of getExternalStorageDirectory#44jishnu7 wants to merge 4 commits intoplay-co:masterfrom
jishnu7 wants to merge 4 commits intoplay-co:masterfrom
Conversation
Former one doesn't need WRITE_EXTERNAL_STORAGE permission.
Contributor
Author
|
@martell ping |
Contributor
|
Yes I agree we should not really be using the root path to the SD card and should be using I will need a bit of time to test this on a few different game projects to confirm that it is safe. |
jishnu7
pushed a commit
to jishnu7/native-android
that referenced
this pull request
May 5, 2020
* fix repo in package.json * add base gradle prject files and scripts * first modifications to Makefile and build.js * fixed android seed * fixing links.json path * fix java src title folder renaming * rename project folder to package name * updated linked package * fixed typo in arg * bump min version * fix ndk project path * fixed path to native build script * debug path * gradle apk assembling completed, no native.js copied (it is next todo) * fixed native.js copying, gitignore, couple build.js settings (updateManifest is todo) * completed assembling apk with gradle, injectAppLinks and injectPluginXML are NOT tested * Removing all files in .gitignore * removed jni/gen from gitignore * fixed gitignore * put back removed gradle dir * fixed injectAppLinks, start modifiying injectPluginsXML with gradle not fixed * update gradle to use local jars and copy necessary files and insert plugins settings in manifest and other files * fixed submodule native-core * update readme * minSdk 23 -> 21 * fixes to update appcompat lib version * armeabi-v7a only * issue 6 , template script should be work for both Mac and Linux * tested on clean ubun thu, issue 3 (license acceptance) fixed) * formatting template * fixed issue-1 remove project folder before use gradle script to copy seed project * added error solving description to read me, removed error from gradle template script * added native build file * added scripts to inject gradle dependencies from plugins settings, not all plugins fixed to support, only Flurry and gameplay * moving from gcm to fcm for gameplay plugin, moving to oficcial latest OneSignal installation instruction without gcm dependencies using Android OneSignal plugin. Not done, still couple todos in build.js * fixed migrations and plugins dependencies in gradles imsertion * update kochava * fixes for build.js * paralelization fix, install bulk jars fix * added repos insertion into build.gradle and proguard insertion into teleaf/proguard * updates for plugins * fix proguard syntax * various changes and updates (js assets/resources * rm -rf moved to more earlier hook in devkit-core/native-android.js * fixes for gradle injection * bump up gradle version and gradle plugin version to avoid build issues * fixed realeased apk zipalign and sign * clean Makefile and scripts/analyze.sh * versionCode and versionName insertion in app/build.gradle * fixed app label * apk dev fixes * fixed signing for debug app * removed redundant argument in readme * fix versioning if version is empty * fixed java version switch for Ubuntu, fixed desccription if expect tool not found * small fixes * fixed blinking activity * removed redundant xsl parameters * downgrade min sdk * modified proguard * fixed AsyncTask import * enabled multiDex for tealeaf module * Update README.md * Update package.json * removed file and fixed gitignore * removed generated files from git cache * preinstall fixes * changed path to preinstall * added barista * fixed barista preparation, but dust does not work still * removing ndk generated objects * put profiler back * barista generation fixed and works * put barista generated C++ V8 files * app_links android:autoVerify=true added * lowered ndk min build version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Former one doesn't need WRITE_EXTERNAL_STORAGE permission.
This might need testing. Tested only on one of the game we were working on.