Apply source visibility to lens fields#9
Open
aethertap wants to merge 2 commits intoplausiblelabs:masterfrom
Open
Apply source visibility to lens fields#9aethertap wants to merge 2 commits intoplausiblelabs:masterfrom
aethertap wants to merge 2 commits intoplausiblelabs:masterfrom
Conversation
commit 337c64d44d68c5e67c4c2cf450b56fd471eec2b4
Author: Erik Lee <erik@human20project.com>
Date: Thu Nov 26 21:29:38 2020 -0600
attempt to apply source visibility to lens fields
Don't descend further into fields if they are marked as leaves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lens fields were always private, which prevented using the lenses in places where visibility matters. This is intended to copy the field visibility from the source file and apply it to the lens field. I am not experienced with derive macros, so this is basically just adapted from code earlier in this file for the struct visibility, but it appears to solve the problem I was having.