JACOBIN-862 improve float and double operation accuracy #435
+320
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platypusguy
reviewed
Jan 21, 2026
Owner
platypusguy
left a comment
platypusguy
left a comment
There was a problem hiding this comment.
In doFrem() can't the push be:
push(fr, float64(float32(math.Mod(val1), (val2))) ?
I don't think you need to convert val1 and val2 to float64 before doing the mod.
Collaborator
Author
|
val1 must be a float32 quantity, cast from a 64-bit stack entry quantity. This ensures that the value fits in a Java float. If these were integer casts we could do cheaper bit mask operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new unit test file: jvm/double_precision_repro_test.go
modified: jvm/interpreter.go