Skip to content

Conversation

@kevindetry-milaboratories
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @kevindetry-milaboratories, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the display of block titles by transitioning from an editable field to a static 'Samples & Data' title. To enhance user context, a new dynamic subtitle has been implemented, which provides real-time information about the number of datasets. Additionally, this PR includes comprehensive updates to various project dependencies, ensuring the use of the latest library versions and improving overall stability and compatibility.

Highlights

  • Removed Editable Block Title: The functionality for an editable block title has been removed, making the block title a static value.
  • Added Dynamic Subtitle: A new dynamic subtitle has been introduced to display the current number of datasets, providing more context to the user.
  • Dependency Updates: Various project dependencies, including core and UI SDKs, as well as other libraries, have been updated to their latest versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the editable block title, replacing it with a static title and a new dynamic subtitle that displays the number of datasets. The changes are consistent across the model, UI, and workflow, and the implementation is straightforward. My main feedback is about the repeated use of the hardcoded string "Samples & Data" in multiple files. To improve maintainability and adhere to the DRY principle, this string should be defined as a shared constant.

)

.title((ctx) => ctx.args.blockTitle ?? 'Samples & Data')
.title(() => 'Samples & Data')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The title 'Samples & Data' is hardcoded. This string is also used in other places, such as ui/src/pages/MetadataPage.vue and workflow/src/main.tpl.tengo. To follow the DRY (Don't Repeat Yourself) principle and improve maintainability, consider defining this as a constant in a shared location (e.g., in the model package) and importing it where needed. This makes future changes to the title easier to manage across the application.

placeholder="Samples & Data"
/>
</template>
<PlBlockPage title="Samples & Data">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The title 'Samples & Data' is hardcoded here. This string is also used in model/src/index.ts. To adhere to the DRY principle, this should be a shared constant imported from the model package.


trace := pSpec.makeTrace(undefined,
{type: "milaboratories.samples-and-data", id: blockId, importance: 10, label: blockTitle},
{type: "milaboratories.samples-and-data", id: blockId, importance: 10, label: "Samples & Data"},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The label 'Samples & Data' is hardcoded. This string is also used in the frontend (model and ui packages). For consistency, it would be ideal to use a shared constant. If sharing a constant between TypeScript and Tengo is not straightforward, at least consider defining it as a local constant at the top of this file to avoid magic strings.

@kevindetry-milaboratories kevindetry-milaboratories added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit aadbb76 Jan 12, 2026
8 checks passed
@kevindetry-milaboratories kevindetry-milaboratories deleted the push-xqxwrlmszxlm branch January 12, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants