Skip to content

Conversation

@mzueva
Copy link
Contributor

@mzueva mzueva commented Jan 8, 2026

MILAB-5322 Show running state for tables and graphs, migrate to new project template

@gemini-code-assist
Copy link

Summary of Changes

Hello @mzueva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to display the running state for tables and graphs, providing better feedback on their operational status. Concurrently, it undertakes a comprehensive migration to a new project template, which modernizes the build process, standardizes development configurations, and updates various dependencies across the codebase for improved maintainability and consistency.

Highlights

  • Running State Display: The model module has been updated to use outputWithStatus for graphPFrame and table outputs, enabling the display of their running states in the UI.
  • Project Template Migration: A significant migration to a new project template has been performed, involving extensive changes to build configurations, dependency management, and TypeScript settings across model, ui, test, and workflow modules. This includes adopting ts-builder and standardizing tsconfig.json files.
  • Build System Refinement: The build system has been streamlined by removing prettier configuration, consolidating turbo.json tasks for lint, type-check, and build, and updating package.json scripts to reflect the new ts-builder and block-tools usage.
  • Dependency Updates: The pnpm-workspace.yaml file has been updated with newer, often exact, versions of SDK packages and common dependencies. The polars-lts-cpu Python dependency was also updated to 1.33.1.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request accomplishes two main objectives: migrating the project to a new template and adding a 'running' state indicator for tables and graphs. The migration to the new project template is extensive, touching most configuration files to adopt ts-builder, centralized TypeScript configurations, and updated dependencies. The scripts in package.json and turbo.json have also been refactored, which is a good improvement.

The core feature of showing a running state is implemented by using outputWithStatus in the model, which is a clean approach. I've found a critical issue in the new turbo.json configuration that introduces a circular dependency, which could break your CI/CD pipeline. I've also left a suggestion in model/src/index.ts to improve code robustness and consistency. Overall, a great set of changes once the critical issue is addressed.

@mzueva mzueva merged commit b09eb6a into main Jan 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants