-
Notifications
You must be signed in to change notification settings - Fork 0
Show running state for tables and graphs #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @mzueva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the capability to display the running state for tables and graphs, providing better feedback on their operational status. Concurrently, it undertakes a comprehensive migration to a new project template, which modernizes the build process, standardizes development configurations, and updates various dependencies across the codebase for improved maintainability and consistency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request accomplishes two main objectives: migrating the project to a new template and adding a 'running' state indicator for tables and graphs. The migration to the new project template is extensive, touching most configuration files to adopt ts-builder, centralized TypeScript configurations, and updated dependencies. The scripts in package.json and turbo.json have also been refactored, which is a good improvement.
The core feature of showing a running state is implemented by using outputWithStatus in the model, which is a clean approach. I've found a critical issue in the new turbo.json configuration that introduces a circular dependency, which could break your CI/CD pipeline. I've also left a suggestion in model/src/index.ts to improve code robustness and consistency. Overall, a great set of changes once the critical issue is addressed.
MILAB-5322 Show running state for tables and graphs, migrate to new project template