-
Notifications
You must be signed in to change notification settings - Fork 0
update graph-maker version #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @erohinaelena, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on synchronizing the project's dependencies by updating several core internal packages to their latest versions. This ensures compatibility, incorporates recent bug fixes, and leverages new features from the updated libraries, maintaining the overall health and stability of the project's dependency tree. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies, most notably @milaboratories/graph-maker to version 1.1.196. The changes also include updates to other @milaboratories and @platforma-sdk packages. The lockfile and workspace configuration have been updated accordingly. My review found one potential issue regarding dependency version consistency. The updated @milaboratories/graph-maker package depends on an older version of @platforma-sdk/ui-vue, which might lead to having two different versions of this package in the final bundle. Please see my specific comment for details.
| zod: 3.23.8 | ||
|
|
||
| '@milaboratories/graph-maker@1.1.195(d3-dispatch@3.0.1)(d3-path@3.1.0)(d3-scale-chromatic@3.1.0)(sortablejs@1.15.6)(typescript@5.9.2)': | ||
| '@milaboratories/graph-maker@1.1.196(d3-dispatch@3.0.1)(d3-path@3.1.0)(d3-scale-chromatic@3.1.0)(sortablejs@1.15.6)(typescript@5.9.2)': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated @milaboratories/graph-maker@1.1.196 still depends on an older version of @platforma-sdk/ui-vue (1.47.5), while other parts of the workspace are being updated to ^1.48.0. This will result in two versions of @platforma-sdk/ui-vue being included in the final bundle, which can increase its size and potentially cause issues. It would be best if @milaboratories/graph-maker was also updated to use @platforma-sdk/ui-vue@^1.48.0 for consistency.
No description provided.