add backoff for migration pod checking logs #1396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Comment on lines
+171
to
+172
| oldCutoverLabel := pod.Labels["startCutover"] | ||
| newCutoverLabel := utils.SetCutoverLabel(migration.Spec.InitiateCutover, oldCutoverLabel) |
Contributor
There was a problem hiding this comment.
The variable naming here could be improved for clarity. The function name SetCutoverLabel suggests it's modifying something, but it's actually returning a value. Consider renaming the function to something like GetCutoverLabelValue or renaming the variables to make the intent clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR increases requeue time for "pod not found" issue.
Makes update call only if there is actual change.
this will reduce the reconcile frequecy.
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #1273
Special notes for your reviewer
Testing done
TBD